refactor: fix agg_ops.DiffOp for Datetime and Timestamp#2296
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-labelbot added size: m 
chelsea-linforce-pushed the main_chelsealin_diff branch from d45df3f to fe3c7c1Comparechelsea-linforce-pushed the main_chelsealin_diff branch from fe3c7c1 to 1eaa3e3Compare
sycai reviewed Nov 26, 2025
| snapshot.assert_match(sql, "out.sql") | ||
| deftest_diff(scalar_types_df: bpd.DataFrame, snapshot): |
Contributor
There was a problem hiding this comment.
Could you parameterize this test on the column name? go/tott/726
sycai approved these changes Nov 26, 2025
chelsea-lin merged commit 33a211e into main 20 of 25 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change aims to fix the
test_timestamp_series_diff_aggtest failing in #2248.Fixes internal issue 417774347 🦕