refactor: Handle special float values and None consistently in sqlglot _literal#2337
+74 −19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-labelbot added size: s 
chelsea-linforce-pushed the main_chelsealin_literal branch from 85292df to ca3023aCompareproduct-auto-labelbot added size: m 
chelsea-linforce-pushed the main_chelsealin_literal branch from ca3023a to 1b28f4cComparechelsea-linforce-pushed the main_chelsealin_literal branch from 1b28f4c to 60d3483Compare
sycai approved these changes Dec 19, 2025
chelsea-lin merged commit 7d152d3 into main 24 of 25 checks passed
Uh oh!
There was an error while loading. Please reload this page.
shuoweil pushed a commit that referenced this pull request Dec 19, 2025
…t _literal (#2337) This change can resolve two doctests failures in #2248: `groupby.GroupBy.rank` and `bigframes.ml.metrics.roc_curve` Fixes internal issue 417774347🦕 --------- Co-authored-by: Shenyang Cai <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change can resolve two doctests failures in #2248:
groupby.GroupBy.rankandbigframes.ml.metrics.roc_curveFixes internal issue 417774347🦕