_config.yml: Don't explicitly specify markdown engine.#50
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
neelance commented Feb 22, 2016
Yeah. I'm okay with merging and then checking the output. |
MemberAuthor
dmitshur commented Feb 22, 2016
Let's try. Will revert if I spot any issues. |
dmitshur added a commit that referenced this pull request Feb 22, 2016
_config.yml: Don't explicitly specify markdown engine.
MemberAuthor
dmitshur commented Feb 22, 2016
I see some minor differences, but no major issues. Before:
After:
The largest minor issue is that code blocks have a strange 0-width left padding.
|
MemberAuthor
dmitshur commented Feb 22, 2016
On the plus side, no more warning email! |
MemberAuthor
dmitshur commented Feb 22, 2016
FWIW, the HTML before:
And after:
|
Member
neelance commented Feb 22, 2016
Seems like the CSS file needs an update. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#49.
This is not tested. Done based on what the email said in #48 (comment), to remove specifying
markdownoption in the _config.yml.I don't think we're using any subtle features, so the default markdown engine, whatever it may be, should be okay.