Skip to content

Support middlewares for subscriptions#221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Cito merged 10 commits into from
Jul 7, 2024
Merged

Support middlewares for subscriptions #221

Cito merged 10 commits into from
Jul 7, 2024

Conversation

@nrbnlulu
Copy link
Contributor

@nrbnlulunrbnlulu commented Jul 2, 2024•
edited
Loading

Fix#188

I am not sure if this requires more tests because AFAIR its basically the same as async execution.
Please let me know it needs more @Cito

@nrbnlulunrbnlulu requested a review from Cito as a code ownerJuly 2, 2024 11:51
@nrbnlulunrbnlulu mentioned this pull request Jul 2, 2024
Merged
11 tasks
@nrbnlulu
Copy link
ContributorAuthor

nrbnlulu commented Jul 5, 2024

@Cito can you aprove the workflows?

@Cito
Copy link
Member

Cito commented Jul 5, 2024

Thanks, will review this tomorrow.

Cito
Cito requested changes Jul 7, 2024
View reviewed changes
Copy link
Member

@CitoCito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you.

Just minor stylistic changes for consistency, see suggestions.

Cito
Cito requested changes Jul 7, 2024
View reviewed changes
Copy link
Member

@CitoCito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dummy resolver can be removed.

Cito
Cito approved these changes Jul 7, 2024
View reviewed changes
@CitoCito merged commit 876aef6 into graphql-python:mainJul 7, 2024
@nrbnlulunrbnlulu deleted the support-middlewares-for-subscriptions branch July 8, 2024 04:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CitoCitoCito approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can subscriptions have middleware?

2 participants

@nrbnlulu@Cito