Skip to content

Conversation

@erikwrede
Copy link
Member

@erikwredeerikwrede commented Oct 24, 2025

When sorting a schema lexicographically, the enum values lost their extensions.

@codspeed-hq
Copy link

CodSpeed Performance Report

Merging #245 will not alter performance

Comparing erikwrede:fix-keep-enum-value-extensions-on-lex-sorting (72e6445) with main (4b0ada2)

Summary

✅ 14 untouched

@Cito
Copy link
Member

Cito commented Oct 24, 2025

Thank you @erikwrede

@CitoCito merged commit 431b0f5 into graphql-python:mainOct 24, 2025
14 checks passed
@CitoCito changed the title fix: don't loose extensions when sorting enum values lexicographically.fix: don't loose extensions of enum values when sorting schemasOct 24, 2025
@Cito
Copy link
Member

Cito commented Oct 24, 2025

Actually input values and the schema itself had the same problem, fixed that already, and backported it as well.

@erikwrede
Copy link
MemberAuthor

@Cito still meant to check for that, great you found it first :) thanks for the quick merge

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@erikwrede@Cito