Removed where T : new()#323
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Removed where T : new() from the ParseArguments<T> factory method as it shouldn't be required if convention is followed of only mutable classes required a default constructor, and immutable classes are supported and do not have this requirement, so the new() restriction is blocking immutable classes which should typically not have a default constructor.
clmcgrath commented Jul 10, 2017
can we merge this please been over a year waiting on this fix |
ericnewton76 commented Nov 4, 2017
Note: We have moved the project to a more team managed repository. Please resubmit any pull requests to https://github.com/commandlineparser/commandline Sorry for inconveniences. |
ContributorAuthor
You had over a year to deal with this PR, long before you created a new repo. If you still have this issue and still would like to address it feel free to just copy and paste the changes where needed or reimplement your own solution. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed where T : new() from the ParseArguments factory method as it
shouldn't be required if convention is followed of only mutable classes
required a default constructor, and immutable classes are supported and
do not have this requirement, so the new() restriction is blocking
immutable classes which should typically not have a default constructor.
This resolves#310