Allow spaces when tokenizing option-value#334
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ContributorAuthor
To achieve same behavior contained within PR using existing functionality, I need to pass arguments like: ./app --option "first name=Bill;last name=Boga" |
billbogaiv changed the title 
Previous behavior split the incoming token long-name value using the equal sign as the separator. This would cause an option's value containing spaces to get truncated. New behavior does regex. match to make sure format is correct and gets the full value.
billbogaivforce-pushed the allow-spaces-when-tokenizing-option-value branch from 0681660 to 2912a6fComparebillbogaiv changed the title 
Collaborator
nemec commented Jul 20, 2016
Hi @billboga based on the code you replaced I think the problem was actually the |
ContributorAuthor
billbogaiv commented Jul 20, 2016
Yeah, I had two different thoughts in my head when I was typing. What you wrote is what I meant 😄. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous behavior split the incoming token long-name value using the equal sign as the separator.
This would cause an option's value containing spaces to get truncated.
New behavior does regex. match to make sure format is correct and gets the full value.