Fix for missing author null reference (#332)#356
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Newer tools require some config changes. xUnit also has incompatibilities with .Net 4.0 assemblies.
Also changed IList<Attribute> to IEnumerable<Attribute>.
ContributorAuthor
anthonylangsworth commented Oct 1, 2016
There appears to be an issue referencing xUnit in the AppVeyor build. I have tested this on multiple Windows machines with clean clones both using build.cmd and Visual Studio Build. I will continue to investigate. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #332. If any assembly attributes like
AssemblyCompanyAttributeare missing from the assembly, the code no longer throws an exception but calls theonErrorfunction as expected. Includes xUnit tests around assembly attribute use.