Fixed sample code (in README.md)#499
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- `ParseArgumentsStrict` no longer exists - `Parser.Default.ParseArguments<AddOptions, CommitOptions, CloneOptions>` would only work if the `ParseArguments` extension method was in scope via `using CommandLine` so the `CommandLine` prefix is not only redundant but misleading (because one could copy it and not realize why `ParseArguments` seems to have mismatched arguments).
Collaborator
nemec commented Nov 2, 2017
Author
ohadschn commented Nov 3, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParseArgumentsStrictno longer existsParser.Default.ParseArguments<AddOptions, CommitOptions, CloneOptions>would only work if theParseArgumentsextension method was in scope viausing CommandLineso theCommandLineprefix is not only redundant but misleading (as one could copy it and not realize whyParseArgumentsseems to have mismatched arguments, looking atParser.ParseArguments).