BUG/MINOR: handlers: populate sha256_finger_print in SSL certificate responses#396
+36 −33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…responses The SSL certificate storage handlers were not copying the Sha256FingerPrint field from GetCertificatesInfo() to the API response, even though the field is available in client-native's CertificatesInfo struct. This caused clients relying on fingerprint-based change detection to always see certificates as changed, since the fingerprint was never returned.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SSL certificate storage handlers were not copying the Sha256FingerPrint field from GetCertificatesInfo() to the API response, even though the field is available in client-native's CertificatesInfo struct and the field is defined in the OpenAPI spec.