Specify bitrate in a config file?

[randycoulman]

Is there a way to specify the bitrate parameter in a configuration file? From what I can see, there isn't.

I'd like to be able to supply a config file with parameters that work on a CI machine but allow a developer to override those values using environment variables when working on their local workstation. There is already an environment variable for this, but the current code doesn't seem to use a bitrate that was provided in a configuration file.

I saw #172, but that PR doesn't seem to show any actual changes and it was closed without merging after being approved.

Is there a reason why this wouldn't be a desirable feature?

Thanks for a super-handy library! Works great in all of my testing so far!

[felixdivo]

Maybe it should simply pass all arguments to the bus constructor, so you can also use some other interface specific parameters.

[christiansandberg]

This should work. Everything in the config file will be read into the configuration as strings:
https://github.com/hardbyte/python-can/blob/develop/can/util.py#L73

Then the bitrate will be converted to an integer:
https://github.com/hardbyte/python-can/blob/develop/can/util.py#L164

[christiansandberg]

No, it seems broken. In can/interface.py, nothing is propagated to **kwargs. Bitrate was working previously though:
aa44f45#diff-3194f59bb641265893300991077dcd9dL34

[randycoulman]

I'm wondering if something like this would work:

• In Bus.__new__, include all of the kwargs as part of the config being passed to load_config (https://github.com/hardbyte/python-can/blob/develop/can/interface.py#L64-L67)

• Pass the resulting config through to the backend constructor (https://github.com/hardbyte/python-can/blob/develop/can/interface.py#L96)

There'd have to be some other changes as well, like deleting the bustype field before calling load_config and removing the interface and channel entries from the resulting config to handle them as they are now.

But the overall result should be that the config file can provide any valid parameters (including bitrate) for a particular interface and they will make it through to the constructor call.

[felixdivo]

I just wanted to note that I changed some of that config handling in PR #278, specifically here.

[felixdivo]

@randycoulman Has that solved the problem?

[randycoulman]

@felixdivo Sorry, I'm not on that project any more (it was a consulting client) and I don't have access to the codebase to check anything out.