Skip to content

Conversation

@pierreluctg
Copy link
Collaborator

ICS NeoVi device serial above A0000 are base36 encoded and need to be decoded properly.

@pierreluctg
Copy link
CollaboratorAuthor

pierreluctg commented Feb 13, 2018

@hardbyte can we include this one in the 2.1.0 release?

Thank you

@hardbytehardbyte added this to the 2.1 Release milestone Feb 17, 2018
Copy link
Owner

@hardbytehardbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hardbytehardbyte merged commit 10aef50 into hardbyte:developFeb 17, 2018
@pierreluctgpierreluctg deleted the neovi_serial_base36 branch February 23, 2018 20:25
boris-wenzlaff pushed a commit to boris-wenzlaff/python-can that referenced this pull request Mar 23, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pierreluctg@hardbyte