SocketCAN low level fixes#296
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…handle sending more robustly and ctypes gives way better error messages (it includes errno & a human readable description)
CollaboratorAuthor
felixdivo commented Apr 10, 2018
hardbyte approved these changes Apr 17, 2018
| IS_WINDOWS = "windows" in _sys or ("win" in _sys and "darwin" not in _sys) | ||
| IS_LINUX = "linux" in _sys | ||
| IS_OSX = "darwin" in _sys | ||
| IS_UNIX = IS_LINUX or IS_OSX |
Owner
There was a problem hiding this comment.
I'm sure some people would disagree with this definition of UNIX :-P
CollaboratorAuthor
There was a problem hiding this comment.
Yeah sure. But it works here and I could not find anything better in the first Google attempt ;-)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to SocketCAN CTypes:
libc.write(...)might write less bytes than requested, and is now called in a loop until all data has been transmittedcan.socketcan.ctypes failed to transmit-> newcan.socketcan_ctypes failed to transmit: ENETDOWN (errno 100): Network is downChanges to SocketCAN Native:
socket.send(...)might write less bytes than requested, and nowsocket.sendall(...)is usedOther:
test/listener_test.pytest/config.py(it was required by a newly created unit test)