Skip to content

Adding detect_available_configs support to neovi#327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
felixdivo merged 1 commit into from
Jun 14, 2018
Merged

Adding detect_available_configs support to neovi #327

felixdivo merged 1 commit into from
Jun 14, 2018

Conversation

@pierreluctg
Copy link
Collaborator

@pierreluctgpierreluctg commented Jun 13, 2018

No description provided.

felixdivo
felixdivo approved these changes Jun 13, 2018
View reviewed changes
Copy link
Collaborator

@felixdivofelixdivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. After you added the channel(s), please also update #303.

@felixdivo
Copy link
Collaborator

felixdivo commented Jun 14, 2018•
edited
Loading

The CI tests fail because of this:

neovi_bus.py 26 WARNING You won't be able to use the ICS NeoVi can backend without the python-ics module installed!: No module named 'ics'

Not all libraries are installed by this. Maybe we should simply install all optional packages in tests.

@pierreluctg
Copy link
CollaboratorAuthor

pierreluctg commented Jun 14, 2018•
edited
Loading

@felixdivo adding python-ics to tests_require is not a problem. However, using it requires have the neovi driver installed (or in the path) this will be problematic.

For now we can simply return a empty list from detect_available_configs if python-ics is unavailable. What do you think?

@felixdivo
Copy link
Collaborator

felixdivo commented Jun 14, 2018

Hm I see. Sounds good.

@felixdivofelixdivo merged commit 022cb48 into hardbyte:developJun 14, 2018
@felixdivofelixdivo mentioned this pull request Jun 14, 2018
Closed
14 tasks
@pierreluctgpierreluctg deleted the neovi_detect_available_configs branch June 25, 2018 15:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixdivofelixdivofelixdivo approved these changes

Assignees

@pierreluctgpierreluctg

Labels

apibackend:neovi

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pierreluctg@felixdivo