Skip to content

Conversation

@hardbyte
Copy link
Owner

@hardbytehardbyte commented Sep 28, 2018

So to use semantic versioning properly we need to bump the major version when our api changes in a backwards incompatible way.

The changes to the BusABC requiring custom backends to now implement _send_periodic_internal (not to mention all the other changes in the changelog) made me think we should be releasing 3.0 instead of 2.3

Copy link
Collaborator

@felixdivofelixdivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable.

@felixdivofelixdivo added this to the 2.3 Release milestone Sep 29, 2018
@christiansandberg
Copy link
Collaborator

I don’t think it should have been necessary to bump the major number. If an interface implements send_periodic method directly, everything should work just like it did before, right?

@felixdivo
Copy link
Collaborator

The changes to the mesaage class also break comparability in some ways.

@codecov
Copy link

codecovbot commented Sep 30, 2018

Codecov Report

Merging #437 into develop will increase coverage by <.01%.
The diff coverage is 57.14%.

@@ Coverage Diff @@## develop #437 +/- ## ========================================== + Coverage 62.5% 62.5% +<.01%  ========================================== Files 55 55 Lines 4656 4657 +1 ========================================== + Hits 2910 2911 +1  Misses 1746 1746

@hardbytehardbyte merged commit 6a6c641 into developSep 30, 2018
@hardbytehardbyte deleted the feature-update-deprecation-notes branch September 30, 2018 08:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@hardbyte@christiansandberg@felixdivo