Skip to content

Conversation

@felixdivo
Copy link
Collaborator

@felixdivofelixdivo commented Oct 7, 2018

This needs to be done before printing a warning when extended_id is used.

Part of #424.

@felixdivofelixdivo added this to the 3.1 Release milestone Oct 7, 2018
@codecov
Copy link

codecovbot commented Oct 8, 2018

Codecov Report

Merging #455 into develop will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## develop #455 +/- ## ======================================== Coverage 63.72% 63.72% ======================================== Files 55 55 Lines 4672 4672 ======================================== Hits 2977 2977 Misses 1695 1695

@felixdivofelixdivo self-assigned this Oct 8, 2018
@felixdivofelixdivo changed the title Use is_expedned_id instead of extended_id in Message constructorUse is_extedned_id instead of extended_id in Message constructorOct 8, 2018
@felixdivofelixdivo merged commit ea1d2f0 into developOct 8, 2018
@felixdivofelixdivo deleted the fix-is_extended_id branch October 8, 2018 10:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@felixdivo@hardbyte