Skip to content

Conversation

@felixdivo
Copy link
Collaborator

@felixdivofelixdivo commented Feb 10, 2019

This adds a deprecation warning to can.Message.extended_id as discussed in #424.

Further, this PR

  • specifies when specific deprecated members of can.Message will be removed
  • changes len(some_message) to return the DLC instead on len(self.data), so the method also works on remote frames
  • makes can.Message(..., check=True) to actually raise a ValueError and not an AssertionError on invalid parameters, as was documented previously; and also make it run when assertions are disabled
  • adds small improvements and fixes to can.Message, like Unicode errors being avoided
  • adds a hypothesis test for can.Message
  • adds minor cleanups to test/*

@felixdivofelixdivo added this to the 3.1 Release milestone Feb 10, 2019
@felixdivofelixdivo self-assigned this Feb 10, 2019
@codecov
Copy link

codecovbot commented Feb 10, 2019

Codecov Report

Merging #497 into develop will increase coverage by 0.73%.
The diff coverage is 76.74%.

@@ Coverage Diff @@## develop #497 +/- ## =========================================== + Coverage 63.81% 64.54% +0.73%  =========================================== Files 63 63 Lines 5626 5646 +20 =========================================== + Hits 3590 3644 +54 + Misses 2036 2002 -34

@felixdivo
Copy link
CollaboratorAuthor

@hardbyte@christiansandberg Could one of you review this change?

Copy link
Owner

@hardbytehardbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@felixdivo@hardbyte@christiansandberg