Remove support for Python 3.4 + update testing dependencies#532
Uh oh!
There was an error while loading. Please reload this page.
Conversation
Codecov Report
@@ Coverage Diff @@## develop #532 +/- ## ======================================== Coverage 64.46% 64.46% ======================================== Files 63 63 Lines 5651 5651 ======================================== Hits 3643 3643 Misses 2008 2008 |
Uh oh!
There was an error while loading. Please reload this page.
setup.py Outdated
| # Installation | ||
| # see https://www.python.org/dev/peps/pep-0345/#version-specifiers | ||
| python_requires=">=2.7,!=3.0,!=3.1,!=3.2,!=3.3", | ||
| python_requires=">=2.7,!=3.0,!=3.1,!=3.2,!=3.3,!=3.4", |
There was a problem hiding this comment.
Does this mean it won't even try to install on Python 3.4? Do we want that?
There was a problem hiding this comment.
That's at least how we did it with Python 3.0-3.3.
Does this mean it won't even try to install on Python 3.4?
And yes, apparently that's how it should be handled.
I guess we don't want that, since it might work and we just don't guarantee it. But then let's remove everything except python_requires=">=2.7", right?
There was a problem hiding this comment.
I'm just surprised that no one complained about 3.0 through 3.3 not working! I'd have thought we'd get some issues if we remove support for Python 3.4... but then again people running Python3.4 probably aren't going to be running the latest release of python-can either.
I'm okay with you adding the !=3.4
felixdivo commented Mar 12, 2019
We could have a look at this as well: https://setuptools.readthedocs.io/en/latest/setuptools.html#automatic-script-creation |
This removes support for Python 3.4, since it will reach EOL on 2019-03-16 (=next week).
It also updates the testing tools to their current versions.