Skip to content

Test MessageSync#561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
felixdivo merged 17 commits into from
May 8, 2019
Merged

Test MessageSync #561

felixdivo merged 17 commits into from
May 8, 2019

Conversation

@felixdivo
Copy link
Collaborator

@felixdivofelixdivo commented Apr 30, 2019•
edited
Loading

Closes#369.

This PR:

  • add tests for can.MessageSync (a small change to ComparingMessagesTestCase was required)
  • add some types to the docs
  • remove unnecessary logging
  • fixes a possible bug that could have occured when for example the second message has a lower timestamp then the first one (now capps to a minimum 0.0)
  • disable GC while running the (probably for the CI server still too) unreliable test_cycle_time()

Will have to check whether these new tests run reliably on the CI server.

@felixdivofelixdivo self-assigned this Apr 30, 2019
@codecov
Copy link

codecovbot commented Apr 30, 2019•
edited
Loading

Codecov Report

Merging #561 into develop will increase coverage by 0.3%.
The diff coverage is 100%.

@@ Coverage Diff @@## develop #561 +/- ## ========================================== + Coverage 63.7% 64.01% +0.3%  ========================================== Files 63 63 Lines 5700 5699 -1 ========================================== + Hits 3631 3648 +17 + Misses 2069 2051 -18

@felixdivofelixdivo added this to the 3.2 Release milestone May 1, 2019
@felixdivo
Copy link
CollaboratorAuthor

felixdivo commented May 3, 2019

This actually works, it's just AppVeyor being strange. -.-

@felixdivofelixdivo requested a review from hardbyteMay 6, 2019 06:31
hardbyte
hardbyte approved these changes May 7, 2019
View reviewed changes
Copy link
Owner

@hardbytehardbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments that might help long term.

@felixdivofelixdivo merged commit 097bcde into developMay 8, 2019
@felixdivofelixdivo deleted the test-message-sync branch May 8, 2019 07:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hardbytehardbytehardbyte approved these changes

@christiansandbergchristiansandbergAwaiting requested review from christiansandberg

Assignees

@felixdivofelixdivo

Labels

testing

Projects

None yet

Milestone

3.2 Release

Development

Successfully merging this pull request may close these issues.

Add test for can.MessageSync

3 participants

@felixdivo@hardbyte