Skip to content

Conversation

@hasufell
Copy link
Member

No description provided.

Comment on lines +1 to +3
# Releasing

## Release checklist
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this addition!

This has a big overlap with https://github.com/haskell/haskell-language-server/blob/master/docs/contributing/releases.md, we should probably merge these documents.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly... but the other document is old and I've never looked at it.

My suggestion is to have another contributor do a release while I'm available and ask questions when anything in the checklist is unclear... and then we can add more information as we go.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An acceptable merge operation is "discard the old one" :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old list is at least partially up-to-date and contains a lot of detailed information, I would not just delete it.

@fendorfendor enabled auto-merge (rebase) June 28, 2023 13:52
Copy link
Collaborator

@fendorfendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, since this just syncs up the release branch with master.

Comments need to be addressed in follow-up PRs.

@hasufellhasufellforce-pushed the hls-2.0.0.1-forward-port branch from 0792216 to 625608eCompareJune 29, 2023 10:40
@hasufell
Copy link
MemberAuthor

who keeps pushing to master?

@hasufellhasufell requested a review from michaelpjJune 30, 2023 09:59
@michaelpj
Copy link
Collaborator

It's called PR's getting merged ;)

@michaelpjmichaelpj added the merge me Label to trigger pull request merge label Jun 30, 2023
@fendorfendor merged commit 90b18ee into haskell:masterJun 30, 2023
@fendorfendor mentioned this pull request Aug 8, 2023
19 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge meLabel to trigger pull request merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@hasufell@michaelpj@fendor