Skip to content

Conversation

@pull
Copy link

@pullpullbot commented Apr 5, 2022

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

@pullpullbot added the ⤵️ pull label Apr 5, 2022
@review-notebook-app
Copy link

Check out this pull request on ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

# sort values per column, feel free to change the column
df.sort_values("Download", inplace=True, ascending=False)
# clear the screen based on your OS
os.system("cls") if"nt"inos.nameelseos.system("clear")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start_process_with_partial_path: Starting a process with a partial executable path

(at-me in a reply with help or ignore)


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

# when dataframe is empty again
pass
# clear the screen based on your OS
os.system("cls") if"nt"inos.nameelseos.system("clear")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start_process_with_partial_path: Starting a process with a partial executable path

(at-me in a reply with help or ignore)


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

# Deciding and generating question
currenType=choice(questionTypes)

promptEquation=str(choice(numbersRange)) +' '+currenType+' '+str(choice(numbersRange))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blacklist: Standard pseudo-random generators are not suitable for security/cryptographic purposes.

(at-me in a reply with help or ignore)


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

currenType=choice(questionTypes)

promptEquation=str(choice(numbersRange)) +' '+currenType+' '+str(choice(numbersRange))
solution=round(eval(promptEquation), 1)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blacklist: Use of possibly insecure function - consider using safer ast.literal_eval.

(at-me in a reply with help or ignore)


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

# sort values per column, feel free to change the column
df.sort_values("Download", inplace=True, ascending=False)
# clear the screen based on your OS
os.system("cls") if"nt"inos.nameelseos.system("clear")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start_process_with_a_shell: Starting a process with a shell: Seems safe, but may be changed in the future, consider rewriting without shell

(at-me in a reply with help or ignore)


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

# when dataframe is empty again
pass
# clear the screen based on your OS
os.system("cls") if"nt"inos.nameelseos.system("clear")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start_process_with_a_shell: Starting a process with a shell: Seems safe, but may be changed in the future, consider rewriting without shell

(at-me in a reply with help or ignore)


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

# Game Loop
whileTrue:
# Deciding and generating question
currenType=choice(questionTypes)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blacklist: Standard pseudo-random generators are not suitable for security/cryptographic purposes.

(at-me in a reply with help or ignore)


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@@ -0,0 +1,4 @@
matplotlib==3.4.3
numpy==1.21.5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical OSS Vulnerability:

pkg:pypi/[email protected]

2 Critical, 1 Severe, 0 Moderate, 0 Unknown vulnerabilities have been found across 1 dependencies

Components
    pkg:pypi/[email protected]
      CRITICAL Vulnerabilities (2)
        CVE-2021-41495

        [CVE-2021-41495] CWE-476: NULL Pointer Dereference

        ** DISPUTED ** Null Pointer Dereference vulnerability exists in numpy.sort in NumPy &lt and 1.19 in the PyArray_DescrNew function due to missing return-value validation, which allows attackers to conduct DoS attacks by repetitively creating sort arrays. NOTE: While correct that validation is missing, an error can only occur due to an exhaustion of memory. If the user can exhaust memory, they are already privileged. Further, it should be practically impossible to construct an attack which can target the memory exhaustion to occur at exactly this place.

        CVSS Score: 7.5

        CVSS Vector: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H

        CWE: CWE-476

        CVE-2021-41496

        [CVE-2021-41496] CWE-120: Buffer Copy without Checking Size of Input ('Classic Buffer Overflow')

        ** DISPUTED ** Buffer overflow in the array_from_pyobj function of fortranobject.c in NumPy < 1.19, which allows attackers to conduct a Denial of Service attacks by carefully constructing an array with negative values. NOTE: The vendor does not agree this is a vulnerability; the negative dimensions can only be created by an already privileged user (or internally).

        CVSS Score: 7.5

        CVSS Vector: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H

        CWE: CWE-120

      SEVERE Vulnerabilities (1)

        [CVE-2021-34141] CWE-697: Incorrect Comparison

        An incomplete string comparison in the numpy.core component in NumPy before 1.22.0 allows attackers to trigger slightly incorrect copying by constructing specific string objects. NOTE: the vendor states that this reported code behavior is "completely harmless."

        CVSS Score: 5.3

        CVSS Vector: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:L

        CWE: CWE-697

(at-me in a reply with help or ignore)


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

connections_thread.start()
# start sniffing
print("Started sniffing")
sniff(prn=process_packet, store=False)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unbound name: Name sniff is used but not defined in the current scope.

(at-me in a reply with help or ignore)


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

importpandasaspd

# get the all network adapter's MAC addresses
all_macs={iface.macforifaceinifaces.values()}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unbound name: Name ifaces is used but not defined in the current scope.

(at-me in a reply with help or ignore)


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]


optimizer.zero_grad()
# forward pass
outputs=net_dropout(inputs)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call error:NetDropout is not a function.

(at-me in a reply with help or ignore)


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

inputs, labels=inputs.to(device), labels.to(device)
optimizer.zero_grad()
# forward pass
outputs=net(inputs)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call error:Net is not a function.

(at-me in a reply with help or ignore)


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@@ -0,0 +1,158 @@
# %%

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parsing failure: Could not parse file at machine-learning/logistic-regression-in-pytorch/logistic_regression_pytorch.py

(at-me in a reply with help or ignore)


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

# Prompt Loop
whileTrue:
# Clearing the Console on all platforms
os.system('cls'ifos.name=='nt'else'clear')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start_process_with_a_shell: Starting a process with a shell, possible injection detected, security issue.


Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@pullpullbot merged commit efdbb34 into hemanth22:masterNov 18, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@x4nth055@filipe1417@EzzEddin@frenchita