feat: wait for actions using ActionsClient.wait_for#508
Uh oh!
There was an error while loading. Please reload this page.
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #508 +/- ## ========================================== + Coverage 93.43% 93.48% +0.04% ========================================== Files 64 65 +1 Lines 3048 3115 +67 ========================================== + Hits 2848 2912 +64 - Misses 200 203 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jooola changed the title ActionsClient.wait_for and ActionsClient.wait_for_funcActionsClient.{wait_for,wait_for_function}jooola changed the title ActionsClient.{wait_for,wait_for_function}ActionsClient.wait_forjooolaforce-pushed the wait_for_actions branch 2 times, most recently from 34685b8 to 4639148Compare
Uh oh!
There was an error while loading. Please reload this page.
| raise ActionGroupException( | ||
| [ActionTimeoutException(action=action) for action in running] | ||
| ) |
There was a problem hiding this comment.
This hides/ignores any errors for actions that already completed. Should they be included in the Exception or should users that want this behavior pass their own handle_update callable and track these action errors themselves?
There was a problem hiding this comment.
Not entirely sure about this one.
I doubt there is a use case for having the actions that succeeded, we are more focused on the actions that timeout.
I think usage will tell, so I'll start using this in the ansible collection and see how this works out.
There was a problem hiding this comment.
Sorry, I was not clear enough. Besides the actions that time out, maybe the user is also interested in the actions that errored, to show a full picture of the issues.
There was a problem hiding this comment.
If an action failed, we raise ActionFailedException and won't run into the ActionTimeoutException or ActionGroupException. So timeout only happens when everything is still running, hence why we do not handle it here.
There was a problem hiding this comment.
And to actually answer your question: if the users uses the wait_for_function, they might have to managed the errors themselves.
Uh oh!
There was an error while loading. Please reload this page.
jooolaforce-pushed the wait_for_actions branch 2 times, most recently from 8064421 to 0a0046aCompare
This function allows the users to wait for multiple actions in an efficient way. All actions are queried using a single call, which reduce the potential for running into rate limits.
This PR has been marked as stale because it has not had recent activity. The bot will close the PR if no further action occurs. |
This function allows the users to wait for multiple actions in an efficient way. All actions are queried using a single call, which reduce the potential for running into rate limits.