Skip to content

Conversation

@jacoor
Copy link

There is an issue that intercom sometimes spits NONE in response. Flatstorage is dict instance, so will survive none.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.06% when pulling 9275638 on ArabellaTech:master into 949056d on jkeyes:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.06% when pulling fbe093d on ArabellaTech:master into 949056d on jkeyes:master.

@jkeyes
Copy link
Contributor

@jacoor thanks for the PR. I followed the same rules as the official Ruby wrapper. I'll ask them why they preclude None/nil. I don't see a reason not to.

@jkeyes
Copy link
Contributor

Fixed and now in version 2.0, available from PyPi. See 8ca7d74 for the change and tests.

Thanks again, I've added your profile to the AUTHORS page.

@jkeyesjkeyes closed this May 12, 2015
@jacoor
Copy link
Author

Thank You!

2015-05-12 16:22 GMT+02:00 John Keyes [email protected]:

Closed #90#90.

Reply to this email directly or view it on GitHub
#90 (comment).

Jacek Ostański
Internet Evolution - Strony i serwisy Internetowe
608-230-735

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jacoor@coveralls@jkeyes