Change iOS deployment target for Xcode 12#286
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Econa77 reviewed Feb 23, 2021
Uh oh!
There was an error while loading. Please reload this page.
Econa77force-pushed the hotfix/DeploymentTargetXcode12 branch from d38b961 to e329846Compare
This removes the warning about iOS 8 no longer being supported in Xcode 12 while maintaining support for older versions of Xcode. Technically checking the compiler version isn’t an exact 1:1 for checking for Xcode version, but in practice should work in all scenarios.
Econa77force-pushed the hotfix/DeploymentTargetXcode12 branch from 17f6c26 to 2292b02CompareEcona77 approved these changes Jan 1, 2022
Collaborator
Econa77 left a comment
Econa77 left a comment There was a problem hiding this comment.
Thanks.
I've made some additional changes. If you are still having problems, please create the PR again 👍
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the warning about iOS 8 no longer being supported in Xcode 12 while maintaining support for older versions of Xcode. Technically checking the compiler version isn’t an exact 1:1 for checking for Xcode version, but in practice should work in all scenarios.
Quote: TimOliver/TOCropViewController@1311b59