Restructure the Solution for 'Army of Functions' task and Fix Typos#2081
Uh oh!
There was an error while loading. Please reload this page.
Conversation
|
iliakan commented Aug 27, 2020
Anything wrong with the SVG? |
Encountered some problem on my end. Everything fixed now!
I fixed it by replacing the SVG with a new one! |
MuhammedZakirforce-pushed the master branch 3 times, most recently from 07a22fc to 89e3c77Compare
iliakan left a comment
iliakan left a comment There was a problem hiding this comment.
- Please see the comments.
- Split PR please. One PR covers a lot. This way I can accept it partially.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| ```js run demo | ||
| functionmakeArmy(){ | ||
| As you can see above, on each iteration of a `while{...} ` block, a new lexical environment is created. This implies that as long as we store the value of `i` in a variable in the `while{...}` block, created Lexical Environment will have that variable with value of `i`. |
There was a problem hiding this comment.
The second phrase is hard to understand.
There was a problem hiding this comment.
created Lexical Environment will have that variable with value of
i.
^This?
There was a problem hiding this comment.
This implies that as long as we store the value of i in a variable in the while{...} block, created Lexical Environment will have that variable with value of i.
There was a problem hiding this comment.
Does the entire sentence not making any sense or is it the way it is phrased? Do you have any idea how to simplify it? I couldn't think of anything atm. :-(
P.S. I think people can grasp the meaning if it is read along with the snippet below.
iliakan commented Sep 3, 2020
Please make different PRs. This one is quite big for review, I keep postponing it. |
Fixjavascript-tutorial#2068 - Army of Functions Fixjavascript-tutorial#2070 - Typo Fixjavascript-tutorial#2056 - Grammatical Error Fixjavascript-tutorial#2074 - Remove semi-colon after function declaration
MuhammedZakir commented Sep 4, 2020
I have removed them. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
iliakan commented Sep 10, 2020
Could you make the requested minor changes please? |
MuhammedZakir commented Sep 10, 2020
Done. |
iliakan commented Sep 10, 2020
I'll merge it and review the part about the task. PLEASE make separate PRs for different articles =) instead of 1 huge PR (multiple branches help). |
iliakan commented Sep 10, 2020
Thanks! |
iliakan commented Sep 10, 2020
@MuhammedZakir I thoroughly re-examined and further updated http://javascript.info/task/make-army, basing on your suggested changes, hope it's even better now. |
Sorry about that! It won't happen again! :-)
Looks good! 👍 I found some grammar mistakes. As I am a bit busy now, I will make a PR later.
You are welcome! :-) Edit: Website is not updated. Are you perhaps updating it manually and not automatically on each new commit? |
Fix grammar and indent some paragraphs. Complements javascript-tutorial#2081.
3 participants
Fix#2068 - Army of Functions
Fix#2070 - Typo
Fix#2056 - Grammatical Error
Fix#2074 - Remove semi-colon after function declaration