Skip to content

Symbol type#115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mariabp wants to merge 11 commits into from
Closed

Symbol type #115

mariabp wants to merge 11 commits into from

Conversation

@mariabp
Copy link

@mariabpmariabp commented Oct 22, 2019

Translation to spanish ready to review :)

@javascript-translate-botjavascript-translate-bot requested a review from a teamOctober 22, 2019 15:33
@CLAassistant
Copy link

CLAassistant commented Oct 22, 2019•
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ mariabp
✅ vplentinax
❌ Developer

Developer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

lizzie136
lizzie136 requested changes Oct 29, 2019
View reviewed changes
Copy link
Member

@lizzie136lizzie136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola @mariabp
esta super genial la traducción, solo hay un pequeño detalle,
en todas las declaraciones le agregaste un espacio extra.
Por ejemplo:
let id = Symbol("id"); , debería ser let id = Symbol("id"); (le quité un espacio entre el let y el id

@javascript-translate-bot
Copy link

javascript-translate-bot commented Oct 29, 2019

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

mariabpand others added 2 commits November 1, 2019 11:35
@mariabp
Update article.md
de0b438
Listo! Ya eliminé los espacios extras, que raro que los puse 🤔 . Me dices que te parece :)
Deleted extra space between declaration and name of variable
0a786f0
@mariabp
Copy link
Author

mariabp commented Nov 8, 2019•
edited
Loading

Done

@lizzie136lizzie136 self-requested a review November 15, 2019 15:50
lizzie136
lizzie136 approved these changes Nov 15, 2019
View reviewed changes
Copy link
Member

@lizzie136lizzie136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

tscandalitta
tscandalitta reviewed Nov 20, 2019
View reviewed changes
1-js/04-object-basics/03-symbol/article.md Outdated
```

Symbols are guaranteed to be unique. Even if we create many symbols with the same description, they are different values. The description is just a label that doesn't affect anything.
Los Symbols están garantizados a ser únicos. Aunque declaremos varios Symbols con la misma descripción éstos tendrán valores distintos. La descripción es solamente una etiqueta que no afecta nada más.
Copy link
Collaborator

@tscandalittatscandalittaNov 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Se garantiza que los símbolos son únicos" me parece que suena más natural, lo dejo a tu criterio.
"Aunque declaremos varios Symbols con la misma descripción, éstos ..."

Copy link
Author

@mariabpmariabpNov 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Estoy de acuerdo contigo!

tscandalitta
tscandalitta reviewed Nov 20, 2019
View reviewed changes
1-js/04-object-basics/03-symbol/article.md Outdated

````warn header="Symbols don't auto-convert to a string"
Most values in JavaScript support implicit conversion to a string. For instance, we can `alert` almost any value, and it will work. Symbols are special. They don't auto-convert.
````warn header="Symbols no se auto convierten a String"
Copy link
Collaborator

@tscandalittatscandalittaNov 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto-convierten, para ser consistentes

tscandalitta
tscandalitta reviewed Nov 20, 2019
View reviewed changes
1-js/04-object-basics/03-symbol/article.md Outdated
## Propiedades "Ocultas"

Symbols allow us to create "hidden" properties of an object, that no other part of code can occasionally access or overwrite.
Los Symbols nos permiten crear propiedades "ocultas" en un objeto, las cuales ninguna otra parte del código puede accesar ni sobre-escribir.
Copy link
Collaborator

@tscandalittatscandalittaNov 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Los Symbols nos permiten crear propiedades "ocultas" en un objeto, a las cuales ninguna otra parte del código puede acceder ni sobre-escribir.

@tscandalitta
Copy link
Collaborator

tscandalitta commented Nov 20, 2019

No se debe traducir los nombres de las variables, por ejemplo de "user" a "usuario"

Don't translate variables, classes, identifiers.

@vplentinaxvplentinax changed the title First translationSymbol typeJun 7, 2020
@iliakaniliakan mentioned this pull request Jun 7, 2020
Open
@vplentinax
Copy link
Contributor

vplentinax commented Jun 7, 2020

Revisenlo para yo agregar los cambios y no tener que volverlos a revisar una vez arregle el conflicto de estructura.

joaquinelio
joaquinelio requested changes Jun 8, 2020
View reviewed changes
Copy link
Member

@joaquineliojoaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezzep66
te lo paso porque puse varias cosas

@javascript-translate-bot
Copy link

javascript-translate-bot commented Jun 8, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@vplentinax
Copy link
Contributor

vplentinax commented Jun 10, 2020

/done

@vplentinaxvplentinax mentioned this pull request Jun 13, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tscandalittatscandalittatscandalitta left review comments

@joaquineliojoaquineliojoaquinelio requested changes

@lizzie136lizzie136lizzie136 approved these changes

@caballerofcaballerofAwaiting requested review from caballerof

@EzequielCasteEzequielCasteAwaiting requested review from EzequielCaste

Assignees

No one assigned

Labels

changes requestedneeds +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mariabp@CLAassistant@javascript-translate-bot@tscandalitta@vplentinax@lizzie136@joaquinelio