Skip to content

Strings#126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joaquinelio merged 9 commits into from
Jun 18, 2020
Merged

Strings #126

joaquinelio merged 9 commits into from
Jun 18, 2020

Conversation

@ferueda
Copy link
Contributor

@feruedaferueda commented Dec 6, 2019

String article and tests (tasks and solutions) translated to spanish.

@javascript-translate-botjavascript-translate-bot requested a review from a teamDecember 6, 2019 23:12
spideep
spideep suggested changes Dec 10, 2019
View reviewed changes
1-js/05-data-types/03-string/2-check-spam/solution.md
alert( checkSpam("innocent rabbit") );
alert( checkSpam('compra ViAgRA ahora') );
alert( checkSpam('xxxxx gratis') );
alert( checkSpam("coneja inocente") );
Copy link
ContributorAuthor

@feruedaferuedaDec 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No entiendo el cambio solicitado aquí.

1-js/05-data-types/03-string/article.md Outdated
# Strings

In JavaScript, the textual data is stored as strings. There is no separate type for a single character.
En JavaScript, los datos textuales son almacenados como strings (cadena de caracteres). No hay un tipo de datos separado para caracteres únicos.
Copy link

@spideepspideepDec 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'unitarios' en lugar de 'únicos'. Puesto que se refiere a la cantidad de caracteres no a la exclusividad.

@javascript-translate-bot
Copy link

javascript-translate-bot commented Dec 10, 2019

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

ferueda
ferueda commented Dec 10, 2019
View reviewed changes
1-js/05-data-types/03-string/2-check-spam/solution.md
alert( checkSpam("innocent rabbit") );
alert( checkSpam('compra ViAgRA ahora') );
alert( checkSpam('xxxxx gratis') );
alert( checkSpam("coneja inocente") );
Copy link
ContributorAuthor

@feruedaferuedaDec 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No entiendo el cambio solicitado aquí.

@ferueda
Copy link
ContributorAuthor

ferueda commented Dec 13, 2019

/done

@ferueda
Copy link
ContributorAuthor

ferueda commented Jan 7, 2020

It looks like no one is reviewing these pull requests from the community. If you need help revewing them I can help as a reviewer.

@joaquineliojoaquinelio changed the title Strings article translated to spanishStringsJun 8, 2020
@iliakaniliakan mentioned this pull request Jun 8, 2020
Open
joaquinelio
joaquinelio requested changes Jun 17, 2020
View reviewed changes
Copy link
Member

@joaquineliojoaquinelio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cambié Un mont+on!!!!!!!!!! Falta ahora:

  • Restaurar un ejercicio (lo marqué)
  • 79 - Restaurar una tabla y retraducirla.(faltan items y descripciones)
  • 135, 150 - Revisar formato con inglés: el suggest arruina los marckup triple comilla `
    VOLVERÉ con un editor bueno

@javascript-translate-bot
Copy link

javascript-translate-bot commented Jun 17, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@joaquinelio
Apply suggestions from code review
1f96e20
 37 cambios que me atreví a hacer sin permiso tildes, gramática, y err de concepto mas lineas que no habian sido traducidas adrede
@joaquinelio
Update article.md
10be5cb
Actualización grossa
@joaquinelio
Update article.md
ed4d11c
ortografía
@joaquineliojoaquinelio merged commit fb3b99c into javascript-tutorial:masterJun 18, 2020
@javascript-translate-bot
Copy link

javascript-translate-bot commented Jun 18, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquineliojoaquineliojoaquinelio approved these changes

+1 more reviewer

@spideepspideepspideep requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ferueda@javascript-translate-bot@spideep@joaquinelio@vplentinax