Skip to content

Conditional operators: if, '?' #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
EzequielCaste merged 37 commits into from
Jun 20, 2020
Merged

Conditional operators: if, '?' #231

EzequielCaste merged 37 commits into from
Jun 20, 2020

Conversation

@vplentinax
Copy link
Contributor

@vplentinaxvplentinax commented Jun 5, 2020

Este PR es la corrección al articulo traducido por el colaborador Giorgiosaud Conditional if #95 . Dicho PR será cerrado y reenumerado en el Issue 17.

@javascript-translate-botjavascript-translate-bot requested a review from a teamJune 5, 2020 18:23
@iliakaniliakan mentioned this pull request Jun 5, 2020
Open
@joaquinelio
Copy link
Member

joaquinelio commented Jun 5, 2020•
edited
Loading

Les recuerdo, acá el giorgio editó los SVG.
No se editan, hay un procedimiento parametrizado para traducirlos.

joaquinelio
joaquinelio previously requested changes Jun 14, 2020
View reviewed changes
Copy link
Member

@joaquineliojoaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si corrigen la ortografía que sugerí,
que el segundo reviewer que haga el merge

@javascript-translate-bot
Copy link

javascript-translate-bot commented Jun 14, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

vplentinaxand others added 19 commits June 16, 2020 12:11
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
e9b7747
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
c72776f
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
1c10a2b
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
643b511
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
26f6448
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
dfe7d40
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
7977b4a
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/2-check-standard/task.md
e2bb1ec
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/5-rewrite-if-question/task.md
0bb1510
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
adefcea
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
10bdedb
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
50ed670
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
fc95df9
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
d6686c0
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
96c3ae7
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
341830f
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
fbbb9c0
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
a29d26e
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 1-js/02-first-steps/10-ifelse/article.md
18cac2f
Co-authored-by: joaquinelio <[email protected]>
@vplentinax
Copy link
ContributorAuthor

vplentinax commented Jun 16, 2020

/done

@javascript-translate-botjavascript-translate-bot requested a review from a teamJune 16, 2020 16:30
EzequielCaste
EzequielCaste requested changes Jun 20, 2020
View reviewed changes
@javascript-translate-bot
Copy link

javascript-translate-bot commented Jun 20, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@EzequielCasteEzequielCaste merged commit cb0982e into javascript-tutorial:masterJun 20, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EzequielCasteEzequielCasteEzequielCaste approved these changes

@joaquineliojoaquineliojoaquinelio left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vplentinax@joaquinelio@javascript-translate-bot@EzequielCaste