Skip to content

Class inheritance#274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vplentinax merged 6 commits into from
Jul 7, 2020
Merged

Class inheritance #274

vplentinax merged 6 commits into from
Jul 7, 2020

Conversation

@cortizg
Copy link
Contributor

@cortizgcortizg commented Jun 22, 2020

Replacing PR #177

@javascript-translate-botjavascript-translate-bot requested a review from a teamJune 22, 2020 20:25
@javascript-translate-bot
Copy link

javascript-translate-bot commented Jun 22, 2020

Error: the article already has PR number in the Progress Issue #17, it's 171 ⁉️

@iliakaniliakan mentioned this pull request Jul 5, 2020
Open
joaquinelio
joaquinelio requested changes Jul 5, 2020
View reviewed changes
Copy link
Member

@joaquineliojoaquinelio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Override: "montarse encima", a veces decimos "pisar", no es "anular" en programación.
puse sobrescribir en los suggest, tampoco me convence BUSCAR MEJOR PALABRA

Sí podrías ANULAR un método, "sobrescribiendo" uno vacío, pero es más amplio que eso.
Podes reemplazarlo, para que haga algo distinto,
También podes extenderlo, eso es lo que haces con el contructor cuando llamás super(),
edit:
No quise usar "extender", que tiene su propia concepto "extend" para clases,
pero es eso. Podriamos usa expandir...

@javascript-translate-bot
Copy link

javascript-translate-bot commented Jul 5, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@cortizg
Copy link
ContributorAuthor

cortizg commented Jul 7, 2020

/done

@javascript-translate-botjavascript-translate-bot requested a review from a teamJuly 7, 2020 02:28
joaquinelio
joaquinelio approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@joaquineliojoaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vamos resolviendo ya casi contemporáneo... ¡pr de hace dos semanas!
Mejor aun , ya superamos el tercio de repo...

@vplentinaxvplentinax self-requested a review July 7, 2020 15:41
vplentinax
vplentinax approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@vplentinaxvplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!

@vplentinaxvplentinax merged commit 358423e into javascript-tutorial:masterJul 7, 2020
@javascript-translate-bot
Copy link

javascript-translate-bot commented Jul 7, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquineliojoaquineliojoaquinelio approved these changes

@vplentinaxvplentinaxvplentinax approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cortizg@javascript-translate-bot@joaquinelio@vplentinax