Skip to content

Reference Type#304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joaquinelio merged 20 commits into from
Jul 21, 2020
Merged

Reference Type #304

joaquinelio merged 20 commits into from
Jul 21, 2020

Conversation

@maksumi
Copy link
Collaborator

@maksumimaksumi commented Jul 15, 2020

No description provided.

@javascript-translate-botjavascript-translate-bot requested a review from a teamJuly 15, 2020 19:02
@iliakaniliakan mentioned this pull request Jul 15, 2020
Open
joaquinelio
joaquinelio requested changes Jul 16, 2020
View reviewed changes
Copy link
Member

@joaquineliojoaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nada que decir, si no lo entendí.

Corregi los typos al menos.

Andamos escasos de reviewers qye sepan js en profundidad como esto.
Iguual Creo que el capitulo no esta muy deporado en el original...

@javascript-translate-bot
Copy link

javascript-translate-bot commented Jul 16, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Maksumi Murakamiand others added 12 commits July 15, 2020 21:52
@joaquinelio
Update 1-js/99-js-misc/04-reference-type/2-check-syntax/solution.md
827a48a
Co-authored-by: joaquinelio <[email protected]>
@joaquinelio
Update 1-js/99-js-misc/04-reference-type/2-check-syntax/solution.md
f459aff
Co-authored-by: joaquinelio <[email protected]>
@joaquinelio
Update 1-js/99-js-misc/04-reference-type/2-check-syntax/solution.md
90dcbca
Co-authored-by: joaquinelio <[email protected]>
@joaquinelio
Update 1-js/99-js-misc/04-reference-type/3-why-this/solution.md
16fc3ae
Co-authored-by: joaquinelio <[email protected]>
Update solution.md
88604af
Update solution.md
60f27d1
@joaquinelio
Update 1-js/99-js-misc/04-reference-type/article.md
18cfb4c
Co-authored-by: joaquinelio <[email protected]>
@joaquinelio
Update 1-js/99-js-misc/04-reference-type/article.md
a08a5d7
Co-authored-by: joaquinelio <[email protected]>
@joaquinelio
Update 1-js/99-js-misc/04-reference-type/article.md
9fdf550
Co-authored-by: joaquinelio <[email protected]>
@joaquinelio
Update 1-js/99-js-misc/04-reference-type/article.md
a57880d
Co-authored-by: joaquinelio <[email protected]>
@joaquinelio
Update 1-js/99-js-misc/04-reference-type/article.md
06b8de6
Co-authored-by: joaquinelio <[email protected]>
@joaquinelio
Update 1-js/99-js-misc/04-reference-type/article.md
6b51296
Co-authored-by: joaquinelio <[email protected]>
@maksumi
Copy link
CollaboratorAuthor

maksumi commented Jul 16, 2020

/done

@javascript-translate-botjavascript-translate-bot requested a review from a teamJuly 16, 2020 03:19
@maksumi
Copy link
CollaboratorAuthor

maksumi commented Jul 16, 2020

/done

@maksumimaksumi requested review from joaquinelio and removed request for a teamJuly 17, 2020 07:02
Maksumi Murakamiand others added 2 commits July 18, 2020 11:42
@maksumi
Copy link
CollaboratorAuthor

maksumi commented Jul 18, 2020

/done

@javascript-translate-botjavascript-translate-bot requested a review from a teamJuly 18, 2020 16:43
joaquinelio
joaquinelio approved these changes Jul 18, 2020
View reviewed changes
Copy link
Member

@joaquineliojoaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creo que está perfecto en concepto.

typos.

@vplentinax
Copy link
Contributor

vplentinax commented Jul 20, 2020

Corregir typos y aceptamos!

@maksumi
Copy link
CollaboratorAuthor

maksumi commented Jul 20, 2020

/done

@javascript-translate-botjavascript-translate-bot requested a review from a teamJuly 20, 2020 21:22
vplentinax
vplentinax approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@vplentinaxvplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nos fuimos!

@joaquineliojoaquinelio merged commit 17864bb into javascript-tutorial:masterJul 21, 2020
@javascript-translate-bot
Copy link

javascript-translate-bot commented Jul 21, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquineliojoaquineliojoaquinelio approved these changes

@vplentinaxvplentinaxvplentinax approved these changes

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maksumi@javascript-translate-bot@vplentinax@joaquinelio