Skip to content

Basic operators, maths#314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
EzequielCaste merged 15 commits into from
Jul 23, 2020
Merged

Basic operators, maths #314

EzequielCaste merged 15 commits into from
Jul 23, 2020

Conversation

@EzequielCaste
Copy link
Contributor

@EzequielCasteEzequielCaste commented Jul 22, 2020

No description provided.

@javascript-translate-botjavascript-translate-bot requested a review from a teamJuly 22, 2020 15:14
@EzequielCasteEzequielCaste changed the title traducción completa de 08 operatorsBasic operators, mathsJul 22, 2020
@iliakaniliakan mentioned this pull request Jul 22, 2020
Open
@joaquineliojoaquinelio self-requested a review July 22, 2020 19:14
joaquinelio
joaquinelio requested changes Jul 22, 2020
View reviewed changes
Copy link
Member

@joaquineliojoaquinelio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Uh, miren quén está vivo!
¿Un año sabático de un par de dias?
qué perezoso

Con este aporte casi se lee de corrido la primera parte!!!!!!
salvo el exmantainer ric

edit:
ah, no da para review, pero la version inglés 1 2 8 3 solution,
hacen "fix" (¿?) agregan ESPACIOS en lineas 13 y 14... NO ENTIEDO POR QUÉ

edit2:
No está basado en el EN de hace 3 meses
cambia def, titulos y agrega algunas linas al articulo

@javascript-translate-bot
Copy link

javascript-translate-bot commented Jul 22, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

EzequielCasteand others added 10 commits July 22, 2020 19:16
@EzequielCaste@joaquinelio
Update 1-js/02-first-steps/08-operators/1-increment-order/solution.md
7d34563
Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste@joaquinelio
Update 1-js/02-first-steps/08-operators/1-increment-order/solution.md
a11a915
Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste@joaquinelio
Update 1-js/02-first-steps/08-operators/1-increment-order/task.md
500d8e5
Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste@joaquinelio
Update 1-js/02-first-steps/08-operators/3-primitive-conversions-quest…
b14e252
…ions/solution.md Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste@joaquinelio
Update 1-js/02-first-steps/08-operators/3-primitive-conversions-quest…
ef70003
…ions/task.md Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste@joaquinelio
Update 1-js/02-first-steps/08-operators/article.md
0b01e8b
Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste@joaquinelio
Update 1-js/02-first-steps/08-operators/article.md
3fb8d40
Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste@joaquinelio
Update 1-js/02-first-steps/08-operators/article.md
5a008f3
Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste@joaquinelio
Update 1-js/02-first-steps/08-operators/article.md
01716b7
Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste
Update 1-js/02-first-steps/08-operators/article.md
470f5f8
@EzequielCaste
Copy link
ContributorAuthor

EzequielCaste commented Jul 22, 2020

/done

@javascript-translate-botjavascript-translate-bot requested a review from a teamJuly 22, 2020 22:22
@EzequielCasteEzequielCaste removed request for a team and vplentinaxJuly 23, 2020 00:02
joaquinelio
joaquinelio approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@joaquineliojoaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NO LO RELEÍ apenass miré lo que puso maksumi.
Supongo que arreglaste los tipos,
y solo te disscutiría los err de concepto pero no había visto ninguno, so...
apruebo sin leer.

maksumi
maksumi approved these changes Jul 23, 2020
View reviewed changes
Copy link
Collaborator

@maksumimaksumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solo hay unas nuevas sugerencias que veo necesarias, consideralaspor favor. De ahí en fuera: approve!

1-js/02-first-steps/08-operators/4-fix-prompt/solution.md
```js run
let a ="1"; // prompt("First number?", 1);
let b ="2"; // prompt("Second number?", 2);
let a ="1"; // prompt("Primer número?", 1);
Copy link
Collaborator

@maksumimaksumiJul 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

De hecho no... Leelo con tono de pregunta. @joaquinelio

@EzequielCasteEzequielCaste merged commit 33f3ea4 into javascript-tutorial:masterJul 23, 2020
@javascript-translate-bot
Copy link

javascript-translate-bot commented Jul 23, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquineliojoaquineliojoaquinelio approved these changes

@maksumimaksumimaksumi approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@EzequielCaste@javascript-translate-bot@joaquinelio@maksumi