Skip to content

Scripts: async, defer#324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joaquinelio merged 26 commits into from
Jul 29, 2020
Merged

Scripts: async, defer #324

joaquinelio merged 26 commits into from
Jul 29, 2020

Conversation

@dbritto-dev
Copy link
Contributor

@dbritto-devdbritto-dev commented Jul 26, 2020

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jul 26, 2020•
edited
Loading

CLA assistant check
All committers have signed the CLA.

@iliakaniliakan mentioned this pull request Jul 26, 2020
Open
@joaquineliojoaquinelio self-requested a review July 27, 2020 03:47
joaquinelio
joaquinelio requested changes Jul 27, 2020
View reviewed changes
Copy link
Member

@joaquineliojoaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Está bien, typos y tildes

podes aceptar, pelearme o ignorarme...
pero...
Creo que te ofreciste para review?
de los PR, con etiquetas "review needed", son los que no tuvieron revisión
o la tuvieron y el autor hizo/rechazó los cambios
Si está esperando "change req" no creo que valga la pena revisar, que el autor revise primero

@javascript-translate-bot
Copy link

javascript-translate-bot commented Jul 27, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

dbritto-devand others added 19 commits July 27, 2020 00:02
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/02-script-async-defer/article.md
04fe54f
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/02-script-async-defer/article.md
f13cceb
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/02-script-async-defer/article.md
344e441
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/02-script-async-defer/article.md
bb5d273
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev
Update article.md
5c441b2
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/02-script-async-defer/article.md
ad6a1fd
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/02-script-async-defer/article.md
89185ba
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/02-script-async-defer/article.md
6475b1c
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/02-script-async-defer/article.md
f576eb0
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/02-script-async-defer/article.md
656d411
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/02-script-async-defer/article.md
91d7706
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/02-script-async-defer/article.md
83e8176
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/02-script-async-defer/article.md
844042d
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/02-script-async-defer/article.md
e4aecf7
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/02-script-async-defer/article.md
91b3af0
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/02-script-async-defer/article.md
fe973fc
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/02-script-async-defer/article.md
e925239
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/02-script-async-defer/article.md
a0b8670
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/02-script-async-defer/article.md
a2449ac
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev
Copy link
ContributorAuthor

dbritto-dev commented Jul 27, 2020

/done

joaquinelio
joaquinelio approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@joaquineliojoaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.
autor y/o 2do reviewer,
*clic para arreglar nro linea, algo menor
*No estoy convencido de la tabla en 185 (de origen), pero el evento y la relacion con los scripts se explican bien en el art.
Más que ok.

@dbritto-dev
Copy link
ContributorAuthor

dbritto-dev commented Jul 27, 2020

/done

vplentinax
vplentinax approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@vplentinaxvplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@joaquineliojoaquinelio merged commit b565bbb into javascript-tutorial:masterJul 29, 2020
@javascript-translate-bot
Copy link

javascript-translate-bot commented Jul 29, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vplentinaxvplentinaxvplentinax approved these changes

@joaquineliojoaquinelioAwaiting requested review from joaquinelio

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dbritto-dev@CLAassistant@javascript-translate-bot@joaquinelio@vplentinax