Skip to content

Scrolling#330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joaquinelio merged 23 commits into from
Aug 1, 2020
Merged

Scrolling #330

joaquinelio merged 23 commits into from
Aug 1, 2020

Conversation

@Leired7
Copy link
Contributor

@Leired7Leired7 commented Jul 31, 2020

Traducido

@joaquineliojoaquinelio self-requested a review July 31, 2020 21:50
@iliakaniliakan mentioned this pull request Jul 31, 2020
Open
joaquinelio
joaquinelio requested changes Jul 31, 2020
View reviewed changes
Copy link
Member

@joaquineliojoaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Destraduje" propiedades o conceptos que debe conocer en inglés :
relativo a window, limites top-bottom,
Donde se explaya lo dejé en español, salvo donde lo remarca: bottom y se refiere al código

@javascript-translate-bot
Copy link

javascript-translate-bot commented Jul 31, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Leired7and others added 10 commits August 1, 2020 14:37
@Leired7@joaquinelio
Update 2-ui/3-event-details/8-onscroll/1-endless-page/solution.md
d5d58d1
Co-authored-by: joaquinelio <[email protected]>
@Leired7@joaquinelio
Update 2-ui/3-event-details/8-onscroll/1-endless-page/solution.md
efdc7ac
Co-authored-by: joaquinelio <[email protected]>
@Leired7@joaquinelio
Update 2-ui/3-event-details/8-onscroll/1-endless-page/solution.md
f39a7a4
Co-authored-by: joaquinelio <[email protected]>
@Leired7@joaquinelio
Update 2-ui/3-event-details/8-onscroll/1-endless-page/task.md
78a061c
Co-authored-by: joaquinelio <[email protected]>
@Leired7@joaquinelio
Update 2-ui/3-event-details/8-onscroll/3-load-visible-img/task.md
b08da7f
Co-authored-by: joaquinelio <[email protected]>
@Leired7@joaquinelio
Update 2-ui/3-event-details/8-onscroll/article.md
db8261e
Co-authored-by: joaquinelio <[email protected]>
@Leired7@joaquinelio
Update 2-ui/3-event-details/8-onscroll/article.md
75fafd5
Co-authored-by: joaquinelio <[email protected]>
@Leired7@joaquinelio
Update 2-ui/3-event-details/8-onscroll/article.md
35717b6
Co-authored-by: joaquinelio <[email protected]>
@Leired7@joaquinelio
Update 2-ui/3-event-details/8-onscroll/3-load-visible-img/task.md
e2fc3bb
Co-authored-by: joaquinelio <[email protected]>
@Leired7@joaquinelio
Update 2-ui/3-event-details/8-onscroll/1-endless-page/task.md
c4c3fbe
Co-authored-by: joaquinelio <[email protected]>
@Leired7
Copy link
ContributorAuthor

Leired7 commented Aug 1, 2020

/done

@vplentinax
Copy link
Contributor

vplentinax commented Aug 1, 2020

@Leired7 , aún quedaron cambios sin hacer. Fíjate siempre si hay datos "hidden", suelen ocultarlos para no hacer la lista muy larga. 🙈

@Leired7
Copy link
ContributorAuthor

Leired7 commented Aug 1, 2020

/done

joaquinelio
joaquinelio approved these changes Aug 1, 2020
View reviewed changes
Copy link
Member

@joaquineliojoaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

vplentinax
vplentinax approved these changes Aug 1, 2020
View reviewed changes
Copy link
Contributor

@vplentinaxvplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@joaquineliojoaquinelio merged commit 06417d2 into javascript-tutorial:masterAug 1, 2020
@javascript-translate-bot
Copy link

javascript-translate-bot commented Aug 1, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquineliojoaquineliojoaquinelio approved these changes

@vplentinaxvplentinaxvplentinax approved these changes

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Leired7@javascript-translate-bot@vplentinax@joaquinelio