Skip to content

Pointer events#336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joaquinelio merged 27 commits into from
Aug 9, 2020
Merged

Pointer events #336

joaquinelio merged 27 commits into from
Aug 9, 2020

Conversation

@vplentinax
Copy link
Contributor

@vplentinaxvplentinax commented Aug 7, 2020

No description provided.

@vplentinax
Update article.md
dc18542
Arreglando líneas
@iliakaniliakan mentioned this pull request Aug 7, 2020
Open
@joaquineliojoaquinelio self-requested a review August 7, 2020 23:37
joaquinelio
joaquinelio requested changes Aug 8, 2020
View reviewed changes
Copy link
Member

@joaquineliojoaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 Gracias, aprendi algo. A La unica botonera que hice le puse hover zoom para que se vea cool como el menu de la mac,
pero en el celu se rompia, quedaba agrandado e inutil ¿se arregla si uso pointer? veremos...
3 ¿No hay opcion Request Lots of changes? JA! sorry dije que no me queria burlar...

@javascript-translate-bot
Copy link

javascript-translate-bot commented Aug 8, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

vplentinaxand others added 21 commits August 8, 2020 11:53
@vplentinax@joaquinelio
Update 2-ui/3-event-details/6-pointer-events/article.md
deb97b4
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 2-ui/3-event-details/6-pointer-events/article.md
97e4537
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 2-ui/3-event-details/6-pointer-events/article.md
d86fedb
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 2-ui/3-event-details/6-pointer-events/article.md
10c81b3
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 2-ui/3-event-details/6-pointer-events/article.md
4d55e25
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 2-ui/3-event-details/6-pointer-events/article.md
7175e7b
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 2-ui/3-event-details/6-pointer-events/article.md
f145691
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 2-ui/3-event-details/6-pointer-events/article.md
59376b1
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 2-ui/3-event-details/6-pointer-events/article.md
bfcb614
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 2-ui/3-event-details/6-pointer-events/article.md
8f40d5a
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 2-ui/3-event-details/6-pointer-events/article.md
0b55a42
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 2-ui/3-event-details/6-pointer-events/article.md
6b3b3ef
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 2-ui/3-event-details/6-pointer-events/article.md
f957c59
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 2-ui/3-event-details/6-pointer-events/article.md
1efdc0b
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 2-ui/3-event-details/6-pointer-events/article.md
3ca1f6f
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 2-ui/3-event-details/6-pointer-events/article.md
d630da5
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 2-ui/3-event-details/6-pointer-events/article.md
3937dfa
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 2-ui/3-event-details/6-pointer-events/article.md
3eac809
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 2-ui/3-event-details/6-pointer-events/article.md
920f4ed
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 2-ui/3-event-details/6-pointer-events/article.md
092c6e9
Co-authored-by: joaquinelio <[email protected]>
@vplentinax@joaquinelio
Update 2-ui/3-event-details/6-pointer-events/article.md
103727e
Co-authored-by: joaquinelio <[email protected]>
@vplentinax
Copy link
ContributorAuthor

vplentinax commented Aug 8, 2020

/done

joaquinelio
joaquinelio approved these changes Aug 8, 2020
View reviewed changes
Copy link
Member

@joaquineliojoaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maksumi
Copy link
Collaborator

maksumi commented Aug 9, 2020

Si ya lo leyó y reviso @joaquinelio confío en su buen criterio

@joaquinelio
Copy link
Member

joaquinelio commented Aug 9, 2020•
edited
Loading

Si ya lo leyó y reviso @joaquinelio confío en su buen criterio
@maksumi@vplentinax

eh, que no es así como funciona esto...
Pero aprovecho y merjo.

y me diste una idea, hago 2 cuentas anónimas y me autoapruebo sin uds molestando...

ah, en este art
ilya me aprobo un fix typo
y peroche no me aprobo el cambio de "as of now" (sin sugerencias)
asi que me apuro al merge antes de que sea considerado rebelde.

@joaquineliojoaquinelio merged commit 74afc79 into javascript-tutorial:masterAug 9, 2020
@javascript-translate-bot
Copy link

javascript-translate-bot commented Aug 9, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquineliojoaquineliojoaquinelio approved these changes

@maksumimaksumimaksumi approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vplentinax@javascript-translate-bot@maksumi@joaquinelio