Skip to content

Server Sent Events#381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joaquinelio merged 7 commits into from
Sep 21, 2020
Merged

Server Sent Events #381

joaquinelio merged 7 commits into from
Sep 21, 2020

Conversation

@homero304
Copy link
Contributor

@homero304homero304 commented Sep 17, 2020

please review my PR

@javascript-translate-botjavascript-translate-bot mentioned this pull request Sep 17, 2020
Open
joaquinelio
joaquinelio requested changes Sep 20, 2020
View reviewed changes
Copy link
Member

@joaquineliojoaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

muy claro, tá bueno
un par de cositas nomás

@javascript-translate-bot
Copy link

javascript-translate-bot commented Sep 20, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@homero304
Copy link
ContributorAuthor

homero304 commented Sep 20, 2020

/done

joaquinelio
joaquinelio requested changes Sep 20, 2020
View reviewed changes
Copy link
Member

@joaquineliojoaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry por la vuelta
una que sugerí me molesta,

y otra que molestaba no supe sugerir antes.

Molesta tambien lo de "cross origin", no traducirlo ni explicarlo,
pero linkea a FETCH en este mismo capitulo y es donde lo explica asi que es correcto que quede así.

@javascript-translate-bot
Copy link

javascript-translate-bot commented Sep 20, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

vplentinax
vplentinax approved these changes Sep 20, 2020
View reviewed changes
Copy link
Contributor

@vplentinaxvplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@homero304
Copy link
ContributorAuthor

homero304 commented Sep 20, 2020

/done

@joaquineliojoaquinelio merged commit 7de52cc into javascript-tutorial:masterSep 21, 2020
@javascript-translate-bot
Copy link

javascript-translate-bot commented Sep 21, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquineliojoaquineliojoaquinelio approved these changes

@vplentinaxvplentinaxvplentinax approved these changes

Assignees

No one assigned

Labels

needs +1review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@homero304@javascript-translate-bot@joaquinelio@vplentinax@omero329