Skip to content

onload and onerror#393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maksumi merged 35 commits into from
Oct 1, 2020
Merged

onload and onerror #393

maksumi merged 35 commits into from
Oct 1, 2020

Conversation

@dbritto-dev
Copy link
Contributor

@dbritto-devdbritto-dev commented Sep 29, 2020

No description provided.

@dbritto-devdbritto-dev changed the title WIPWIP: onload and onerrorSep 29, 2020
@dbritto-devdbritto-dev marked this pull request as ready for review September 29, 2020 22:56
@dbritto-devdbritto-dev changed the title WIP: onload and onerroronload and onerrorSep 29, 2020
joaquinelio
joaquinelio requested changes Oct 1, 2020
View reviewed changes
Copy link
Member

@joaquineliojoaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jeje, unos cuantos typos,
o aun era wip?
ya no.

@javascript-translate-bot
Copy link

javascript-translate-bot commented Oct 1, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@joaquineliojoaquinelio mentioned this pull request Oct 1, 2020
Open
dbritto-devand others added 9 commits September 30, 2020 20:25
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/03-onload-onerror/article.md
75d2e1b
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/03-onload-onerror/article.md
f602cc6
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/03-onload-onerror/article.md
381618f
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/03-onload-onerror/article.md
a2a972f
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/03-onload-onerror/article.md
a48b291
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/03-onload-onerror/article.md
c772da4
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/03-onload-onerror/article.md
22a7032
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev
Minor changes
59de9de
@dbritto-dev
Merge branch 'onload-onerror' of github.com:danilobrinu/es.javascript…
1c213ea
….info into onload-onerror
@dbritto-devdbritto-dev changed the title onload and onerrorWIP: onload and onerrorOct 1, 2020
@dbritto-devdbritto-dev marked this pull request as draft October 1, 2020 01:33
@dbritto-devdbritto-dev marked this pull request as ready for review October 1, 2020 02:19
@dbritto-devdbritto-dev changed the title WIP: onload and onerroronload and onerrorOct 1, 2020
dbritto-devand others added 15 commits September 30, 2020 21:20
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/03-onload-onerror/article.md
6b8ffa5
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/03-onload-onerror/article.md
22c3bb4
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/03-onload-onerror/article.md
a040bad
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/03-onload-onerror/article.md
6c7b486
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/03-onload-onerror/article.md
c8e731a
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/03-onload-onerror/article.md
465f59d
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/03-onload-onerror/article.md
2c1c826
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/03-onload-onerror/article.md
bcfbdc2
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/03-onload-onerror/article.md
294e010
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/03-onload-onerror/article.md
3a289ba
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/03-onload-onerror/article.md
bc1d411
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/03-onload-onerror/article.md
62027d7
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev@joaquinelio
Update 2-ui/5-loading/03-onload-onerror/article.md
f18878d
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev
Minor changes
a3c9011
@dbritto-dev
Merge branch 'onload-onerror' of github.com:danilobrinu/es.javascript…
24bea0b
….info into onload-onerror
@dbritto-dev
Copy link
ContributorAuthor

dbritto-dev commented Oct 1, 2020•
edited
Loading

@joaquinelio yo creo ya está :)

joaquinelio
joaquinelio approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@joaquineliojoaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

con tarea, creo que ok

si está wip podes ponerlo como draft, que es eso, un wip

vplentinax
vplentinax approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@vplentinaxvplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tutto ok!

@maksumimaksumi merged commit 2ac0516 into javascript-tutorial:masterOct 1, 2020
@joaquinelio
Copy link
Member

joaquinelio commented Oct 2, 2020

@maksumi
al hacer merge verifica que don bot responda, el titulo del pr no coincide asi que lo agregue al issue a mano.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquineliojoaquineliojoaquinelio approved these changes

@vplentinaxvplentinaxvplentinax approved these changes

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dbritto-dev@javascript-translate-bot@joaquinelio@vplentinax@maksumi