Skip to content

Conversation

@oshliaer
Copy link
Contributor

I see no reasons to assume that npm --silent run -- gulp edit | bunyan -o short -l debug takes PATH with ./node_modules/.bin or bunyan has been installed globally.

I don't use bunyan in global scope and I'm using nvm environments. Therefore | bunyan is not found for me.

$> ./edit ru < ./edit: line 15: bunyan: command not found

I assume that users can use their bunyan's environment. Well let's not disturb them.

Please consider my PR for fix this issue.

@CLAassistant
Copy link

CLAassistant commented Jul 5, 2019

CLA assistant check
All committers have signed the CLA.

@iliakaniliakan merged commit ed67b50 into javascript-tutorial:masterJul 5, 2019
@oshliaeroshliaer deleted the fix_linux_bunyan_run branch July 5, 2019 11:47
@oshliaeroshliaer mentioned this pull request Jul 7, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@oshliaer@CLAassistant@iliakan