Fix to expand refs before creating root editor#614
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into an issue when using
$refin the root schema, where the schema in the file referenced doesn't get expanded. Here is an example that reproduces this:{"id": "/schema/a.json", "oneOf": [{"$ref": "/schema/b.json" },{"$ref": "/schema/c.json" } ] }I fixed this be expanding the refs in the root schema before instantiating the root editor.
Also, I had to use node v0.10 in order to run grunt. You may want to make a note of that in the README or upgrade the grunt jshint package to support newer versions of node.