Skip to content

Conversation

@wallrj
Copy link
Member

@wallrjwallrj commented Nov 12, 2024

This is a small part of the work to remove spurious log messages: https://venafi.atlassian.net/browse/VC-33564

In #507 we added a Firefly datagatherer to the venafi-kubernetes-agent chart configmap, but forgot to add RBAC to allow venafi-kubernetes-agent to read the firefly issuer resources.

This causes the following errors to be logged:

datagatherer informer has failed and is backing off
failed to list firefly.venafi.com/v1, Resource=issuers: issuers.firefly.venafi.com is forbidden: User "system:serviceaccount:venafi:venafi-kubernetes-agent" cannot list resource "issuers" in API group "firefly.venafi.com" at the cluster scope

k8s.io/[email protected]/tools/cache/reflector.go:243: failed to list firefly.venafi.com/v1, Resource=issuers: issuers.firefly.venafi.com is forbidden: User "system:serviceaccount:venafi:venafi-kubernetes-agent" cannot list resource "issuers" in API group "firefly.venafi.com" at the cluster scope

Here I've manually added the missing RBAC to the Helm chart.

image

ℹ️ I tried to write a new make verify target to avoid this happening in the future, but it's complicated because venafi-kubernetes-agent relies on a binding to the generic view ClusterRole, to get, list, watch some of the more common API types.
In another PR, we can remove that and instead generate the rbac using the existing preflight agent rbac sub-command.
You can see my attempt in #615

@wallrjwallrj changed the title Add a Firefly clusterrole and clusterrolebinding to the venafi-kubernetes-agent chart[VC-33564] Add a Firefly clusterrole and clusterrolebinding to the venafi-kubernetes-agent chartNov 12, 2024
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's OK to install the RBAC for viewing Firefly custom resources on clusters without Firefly CRD installed.

@wallrjwallrj requested review from maelvls and tfadeyi and removed request for maelvlsNovember 12, 2024 14:09
@wallrjwallrj merged commit 106de76 into masterNov 12, 2024
@wallrjwallrj deleted the VC-33564/add-firefly-rbac branch November 12, 2024 14:17
@wallrjwallrj mentioned this pull request Dec 4, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wallrj@tfadeyi