Normalize null options correctly#254
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixesjvilk#227. The first version of Node where FS functions accepted an options object was version 0.10. Between Node 0.10 and Node 6 inclusive, all falsy values (including the empty string) and functions are replaced with the default options. Only truthy values which are not strings, objects or functions throw a `TypeError`. Node 7 introduced a breaking change: only `null`, `undefined` and functions get replaced with the default options, and any values which are not strings or objects throw a `TypeError`. https://github.com/nodejs/node/pull/7165/files#diff-9a205ef7ee967ee32efee02e58b3482dR39 It is not clear which version of the Node FS API is emulated by BrowserFS, so I have elected to implement the Node 7 behaviour.
Owner
The next major version of BrowserFS will clearly track a specific version of the NodeJS FS API. When starting this project (before Node hit 1.0), I had not anticipated that the fs API would continually evolve. I'll merge this in for now, while acknowledging that there are likely other Node 7-incompatible behaviors. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#227.
The first version of Node where FS functions accepted an options object
was version 0.10. Between Node 0.10 and Node 6 inclusive, all falsy
values (including the empty string) and functions are replaced with the
default options. Only truthy values which are not strings, objects or
functions throw a
TypeError.Node 7 introduced a breaking change: only
null,undefinedandfunctions get replaced with the default options, and any values which
are not strings or objects throw a
TypeError. nodejs/node#7165It is not clear which version of the Node FS API is emulated by
BrowserFS, so I have elected to implement the Node 7 behaviour.