Skip to content

recipe: update 'cryptography' and rm unnecessary dependencies#2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndreMiras merged 1 commit into from
Apr 4, 2020
Merged

recipe: update 'cryptography' and rm unnecessary dependencies #2130

AndreMiras merged 1 commit into from
Apr 4, 2020

Conversation

@SomberNight
Copy link
Contributor

@SomberNightSomberNight commented Apr 3, 2020

Update the cryptography recipe to a newer version, and remove unnecessary dependencies.

  • idna no longer needed since version 2.5
  • asn1crypto no longer needed since version 2.8
  • enum34 is just a backport of python 3.4+ functionality
  • ipaddress is just a backport of python 3.3+ functionality

(I am assuming py2 and old versions of py3 are no longer supported)

@AndreMiras
Copy link
Member

AndreMiras commented Apr 4, 2020•
edited
Loading

Thank you!
The cffi build failed and I'd like to investigate why before merging. It could simply be a missing system dependency, but I'd like to spend time on it as the error is unclear to me.
https://travis-ci.org/github/kivy/python-for-android/jobs/670789002
OK it's something to do with Python3.8 and cffi, I'll look into it later today 👍

AndreMiras added a commit to AndreMiras/python-for-android that referenced this pull request Apr 4, 2020
@AndreMiras
Bumps cffi==1.13.2 fixes under Python 3.8
10cf158
https://bitbucket.org/cffi/cffi/issues/403/build-fails-on-38-dev-pyinterpreterstatekivy#2130 (comment) The error was: ``` c/call_python.c:20:30: error: incomplete definition of type 'struct _is' ```
@AndreMirasAndreMiras mentioned this pull request Apr 4, 2020
Merged
@SomberNight
Copy link
ContributorAuthor

SomberNight commented Apr 4, 2020

I've only tested with python 3.7 :/

@AndreMiras
Copy link
Member

AndreMiras commented Apr 4, 2020

No worries, the fix was merged recently, could you try to rebase on develop to see if it helps with the build now?

@SomberNight
recipe: update 'cryptography' and rm unnecessary dependencies
187f859
- 'idna' no longer needed since version 2.5 - 'asn1crypto' no longer needed since version 2.8 - 'enum34' is just a backport of python 3.4+ functionality - 'ipaddress' is just a backport of python 3.3+ functionality
@SomberNightSomberNightforce-pushed the 202004_recipe_cryptography branch from 8eeb596 to 187f859CompareApril 4, 2020 18:57
@SomberNight
Copy link
ContributorAuthor

SomberNight commented Apr 4, 2020

Sure, rebased now.

AndreMiras
AndreMiras approved these changes Apr 4, 2020
View reviewed changes
Copy link
Member

@AndreMirasAndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good thank you 😄
We had one flaky test on GitHub action due to the pyjnius patching, I've reran it, but we're good for the merge.
Thanks!

@AndreMirasAndreMiras merged commit caf9f4b into kivy:developApr 4, 2020
@opacamopacam mentioned this pull request Apr 10, 2020
Merged
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndreMirasAndreMirasAndreMiras approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SomberNight@AndreMiras