Update Travis CI to use most current k8s server version#665
Uh oh!
There was an error while loading. Please reload this page.
Conversation
k8s-ci-robot added cncf-cla: yes micw523 commented Oct 27, 2018
/cc @roycaihw |
k8s-ci-robot commented Oct 27, 2018
@micw523: ¯\_(ツ)_/¯ DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
scripts/kube-init.sh Outdated
| sudo minikube start --vm-driver=$MINIKUBE_DRIVER --bootstrapper=kubeadm --kubernetes-version=$K8S_VERSION --logtostderr | ||
| # Make sure minikube information is not outdated | ||
| sudo minikube update-context |
There was a problem hiding this comment.
Why do we need to run minikube update-context? I assume it modifies the kubeconfig file to point to the minikube cluster and I'd expect minikube start does that for us already
There was a problem hiding this comment.
It's effectively a safeguard: https://github.com/kubernetes/minikube/blob/master/cmd/minikube/cmd/update-context.go#L36
scripts/kube-init.sh Outdated
| # Make sure minikube information is not outdated | ||
| sudo minikube update-context | ||
| export MINIKUBE_OK="false" |
There was a problem hiding this comment.
Let's not export this variable and make it local
scripts/kube-init.sh Outdated
| # Mount root to fix dns issues | ||
| # Define $HOME since somehow this is not defined | ||
| export HOME=/home/travis |
There was a problem hiding this comment.
This is unexpected. The travis doc mentioned that default the environment variables are available and HOME=/home/travis (do not depend on this value).
If the environment variable is truly missed, I'm wondering if ~ like the previous implementation works for you?
There was a problem hiding this comment.
I think $HOME works in 14.04, but somehow it’s not there in the 16.04 env. I was super surprised as well. ~ doesn’t work since we have to define MINIKUBE_HOME and it does not like itself to be defined ~
| # Mount root to fix dns issues | ||
| # Define $HOME since somehow this is not defined | ||
| export HOME=/home/travis | ||
| sudo mount --make-rshared / |
There was a problem hiding this comment.
Frankly I am not sure. I’ve seen others using it and we had disable dns in our previous script. I think kubedns sometimes does not like the CI environments.
There was a problem hiding this comment.
roycaihw commented Oct 29, 2018
cc @dims |
roycaihw commented Oct 31, 2018
LGTM. Please squash the commits before merging |
micw523force-pushed the k8s-version-upgrade branch from 7f199e0 to e639053Compareroycaihw commented Oct 31, 2018
/lgtm |
k8s-ci-robot added the lgtm k8s-ci-robot commented Oct 31, 2018
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: micw523, roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot added the approved 
3 participants
This PR corrects behavior reported in #660 that causes e2e tests which uses API introduced after 1.7.0 to fail.
Changes:
/assign @roycaihw