Skip to content

Conversation

@weakish
Copy link
Contributor

In _save_to_qiniu_internal_py3():

  • remove unused import
  • remove unused else cause of while True loop

In _save_to_qiniu_internal_py3(): - remove unused import - remove unused else cause of while True loop
@weakishweakish requested a review from ymMay 13, 2019 03:34
@codecov-io
Copy link

codecov-io commented May 13, 2019

Codecov Report

Merging #402 into master will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@ Coverage Diff @@## master #402 +/- ## ========================================== + Coverage 86.91% 86.94% +0.03%  ========================================== Files 29 29 Lines 2835 2834 -1 ========================================== Hits 2464 2464 + Misses 371 370 -1
Impacted FilesCoverage Δ
leancloud/file_.py75.33% <0%> (+0.33%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b8daf9...4ff8f63. Read the comment docs.

ym
ym approved these changes May 13, 2019
Copy link
Contributor

@ymym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymym merged commit dfce76d into leancloud:masterMay 13, 2019
@weakishweakish deleted the refactor_save_to_qiniu_internal_py3 branch May 13, 2019 03:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@weakish@codecov-io@ym