Skip to content

Conversation

@kbaikov
Copy link
Contributor

No description provided.

@kbaikovkbaikovforce-pushed the mypy-fixes6 branch 4 times, most recently from de6092a to c79395dCompareAugust 14, 2025 12:13
@kbaikov
Copy link
ContributorAuthor

Ping @jdavid any comments/review to this PR?

@jdavid
Copy link
Member

Hi @kbaikov , sorry for the delay, have been busy.

-assertObjectType.BLOB==blob.type+assertint(ObjectType.BLOB) ==blob.type

The thing is ObjectType.BLOB == blob.type should work and this should be tested in the unit tests.

If we are to make strict_equality = True then blob.type should return ObjectType.BLOB instead of 3.
But this is likely difficult to do because blob.type is defined in C while ObjectType is defined in Python.

@kbaikov
Copy link
ContributorAuthor

Hi @kbaikov , sorry for the delay, have been busy.

-assertObjectType.BLOB==blob.type+assertint(ObjectType.BLOB) ==blob.type

The thing is ObjectType.BLOB == blob.type should work and this should be tested in the unit tests.

If we are to make strict_equality = True then blob.type should return ObjectType.BLOB instead of 3. But this is likely difficult to do because blob.type is defined in C while ObjectType is defined in Python.

Done.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kbaikov@jdavid