Skip to content

Conversation

@dantti
Copy link
Contributor

Since I needed linuxdeploy-plugin-qt that had the --exclude-libraries working I make the github workflows run on my fork and and have this issue when using a newer (+my patch) linuxdeploy submodule.

@bjorn
Copy link
Contributor

For context, this adjustment is necessary in response to linuxdeploy/linuxdeploy@2b73a21.

It's a bit unfortunate the move happened as part of "Improve logging of failed subprocesses", since it makes it very hard to see what the actual improvement was (I couldn't spot it).

@TheAssassin
Copy link
Member

It's a bit unfortunate the move happened as part of "Improve logging of failed subprocesses", since it makes it very hard to see what the actual improvement was (I couldn't spot it).

You're absolutely right about this. This was rushed a bit. It shouldn't be a big deal to use a tool like Meld and diff the old and new code, though.

At any rate, @dantti please rebase this branch, then we can merge it.

@danttidanttiforce-pushed the dantti/fix_linuxdeploy_log_include branch 2 times, most recently from 70e3e97 to 90703c8CompareAugust 4, 2024 02:04
@danttidanttiforce-pushed the dantti/fix_linuxdeploy_log_include branch from 90703c8 to 3d9d609CompareAugust 11, 2024 14:45
@danttidanttiforce-pushed the dantti/fix_linuxdeploy_log_include branch from 3d9d609 to f5f6ca5CompareOctober 17, 2024 13:30
@dantti
Copy link
ContributorAuthor

@TheAssassin this is ready to be merged, CI is broken due other stuff (which a few are addressed in another PR)

@dantti
Copy link
ContributorAuthor

@TheAssassin ping

@danttidanttiforce-pushed the dantti/fix_linuxdeploy_log_include branch from 268f4d6 to 14541e8CompareAugust 14, 2025 20:30
@dantti
Copy link
ContributorAuthor

rebased again

@TheAssassin
Copy link
Member

Sorry for the delay, have not had any time to review this before.

@TheAssassin
Copy link
Member

Thanks a lot!

@TheAssassinTheAssassin merged commit b41aac6 into linuxdeploy:masterAug 18, 2025
6 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dantti@bjorn@TheAssassin