Add X-Ray daemon#14
Merged
Add X-Ray daemon #14
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dominikschubertforce-pushed the feat_xray-integration branch from 93243a8 to d049984Compare1 task
dominikschubert changed the title 
joe4dev approved these changes Mar 20, 2023
Member
joe4dev left a comment
joe4dev left a comment There was a problem hiding this comment.
LGTM 👍
just minor comments but nothing blocking.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
cmd/localstack/xraydaemon.go Outdated
| xrayConfig.NoVerifySSL=util.Bool(true) // obvious | ||
| xrayConfig.LocalMode=util.Bool(true) // skip EC2 metadata check | ||
| xrayConfig.Region=GetEnvOrDie("AWS_REGION") | ||
| xrayConfig.Logging.LogLevel="dev"// TODO |
Member
There was a problem hiding this comment.
When do we adjust that to avoid log spamming?
The daemon itself should be stable, this might just be interesting for debugging.
Member
There was a problem hiding this comment.
It periodically logs Skipped telemetry data as no segments found or the number of traces sent.
Member
joe4dev commented Mar 20, 2023
The PR description is not up-to-date anymore after the change we introduced for updating the X-Ray TraceId with every request. |
Member
joe4dev commented Mar 20, 2023
Could it be that the runtime starts before the X-Ray daemon due to async |
MemberAuthor
dominikschubert commented Mar 21, 2023
Seems to be related to this issue here: aws/aws-xray-sdk-python#185 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the xray daemon as a dependency and starts the daemon asynchronously.
The daemon is stopped and recorded segments are flushed when init shuts down (see signal handler / shutdown funcs in sandbox).
It's not yet ideal, but it provides parity with the old xray implementation. For proper active & passive tracing with additional generated (sub-)segments we'll need to add a few more things
Other changes:
LOCALSTACK_INIT_LOG_LEVELinternal variable for us to be able to configure the log level in the init binary without re-compiling. I don't think this will be the final setup, since I still want to rework the general log setup here, but it's kinda useful in the meantime.