Skip to content

Conversation

@dominikschubert
Copy link
Member

Avoids the Runtime Handler can only error while starting error logs in localstack when the invocation fails due to an error.

Previously it caused two "error reports", one via /invocations/<invokeid>/error and one via /status/<runtimeid>/<status>.

Copy link
Member

@joe4devjoe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Fixed in joint session with @dominikschubert and @dfangl

@dominikschubertdominikschubert merged commit d69fb6a into localstackJun 5, 2023
@dominikschubertdominikschubert deleted the avoid-duplicate-error-reporting-on-init-error branch June 5, 2023 08:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@dominikschubert@joe4dev@dfangl