Skip to content

Change mode of bootstrap file to 0755 if not executable#21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dfangl merged 1 commit into from
Jul 6, 2023
Merged

Change mode of bootstrap file to 0755 if not executable #21

dfangl merged 1 commit into from
Jul 6, 2023

Conversation

@dfangl
Copy link
Member

@dfangldfangl commented Jul 6, 2023

Motivation

This should resolve Permission denied errors we were seeing when people, most notably on non-unix platforms, uploaded lambda zip files without executable permissions on the bootstrap file.

Changes

  • If a bootstrap file (no distinction which, but the default ones in the image should always be executable) is not executable, it will set the permissions to 755, to ensure it executable under all users. If this is not possible, it will log a warning.

dominikschubert
dominikschubert approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@dominikschubertdominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dfangldfangl merged commit e4d28d8 into localstackJul 6, 2023
@dfangldfangl deleted the set-bootstrap-executable branch July 6, 2023 19:00
@joe4devjoe4dev mentioned this pull request Jul 11, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dominikschubertdominikschubertdominikschubert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dfangl@dominikschubert