Integrate upstream changes v2#24
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Removing the trailing whitespace in the README.md to improve the formatting and readability of the file.
Add Shield.io badges for Go version and GitHub release. Useful for displaying important information in a visually appealing and easily accessible way at a glance. Updated the license badge to standard Shield.io format. As it appears it was incorrect pointing to the badge for 'aws-sam-local'.
Add content table to README.md, making it more convenient for users to find the information they need and enabling them to quickly jump to specific sections.
Add markup to environment variable for better browsing
The content for some bullet points are not correctly indented or spaced. This causes text and code blocks to not be displayed properly, causing confusion for customers. This change indents the content of the bullet points so it is now correctly displayed increasing readability.
* Add missing backslash in docker command * Remove stray "`" from command * Covert code snippet to code block for consistency * Remove extraneous newline * Fix invalid italics and use "_" for consistency * Change (invalid) italics to header Make it consistent with the preceding section that says: "To build the emulator into your image" Also, the stray whitespace before the final asterisk was incorrect. * Add syntax highlighting to code blocks * Add header to content table
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.1.0 to 0.7.0. - [Release notes](https://github.com/golang/net/releases) - [Commits](golang/net@v0.1.0...v0.7.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…am-changes Integrate upstream changes. Notable conflicts: * Makefile: simply upgrade Go version to 1.19 from upstream and use LocalStack changes * go.mod: merge dependency updates from upstream and keep LocalStack changes * go.sum: re-generate * lambda/rapi/server.go: new interop import from upstream (?), otherwise not really conflicts just API updates and by-1-line-neighboring updates
dfangl pushed a commit that referenced this pull request Oct 18, 2023
Member
dfangl commented Oct 18, 2023
Merged with 605fa1c |
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes the previous PR #23 where I squashed the upstream changes instead of merged all commits as is.
Motivation
The official AWS lambda-runtime-init received some upstream updates (typically merged in big blobs from their internal repository). We should update our customized
localstackversion to support the latest features (e.g., response streaming) and updates (e.g., the new Golang version). Beyond smaller doc updates, the main updates were:Background
Internal docs: https://www.notion.so/localstack/Update-RIE-with-upstream-changes-for-response-streaming-18a303b503c54f958cfbee5841ef5402?pvs=4
Changes
Integrates the upstream changes from the AWS
lambda-runtime-initrepo and adjusts the API accordingly (see documented commit log for details).👉 Custom LocalStack changes
git show 6c95d75Testing
Test against the LocalStack test suite.
🧪 The localstack branch
integrate-lambda-init-upstream-changescontains some improved tests for therequest_idpropagation issue. For example:tests.aws.services.lambda_.test_lambda.TestRequestIdHandling.test_request_id_invokeI tested other categories including:
tests.aws.services.lambda_.test_lambda.TestLambdaBaseFeaturestests.aws.services.lambda_.test_lambda.TestRequestIdHandlingTODO
uuidnot being replaced in the testtests.aws.services.lambda_.test_lambda.TestLambdaFeatures.test_invocation_with_qualifierlocalstackbranch back as a quickfix because rebasing again is terrible with so many conflicts 😢