Update lambda init binary#10163
Merged
Update lambda init binary #10163
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dfangl added the semver: patch 
LocalStack Community integration with Pro 2 files 2 suites 1h 24m 2s ⏱️ For more details on these failures, see this check. Results for commit 40e4c3f. ♻️ This comment has been updated with latest results. |
dfanglforce-pushed the update-lambda-init branch from ba06454 to 40e4c3fCompare
coveralls commented Feb 6, 2024
MemberAuthor
dfangl commented Feb 6, 2024
https://github.com/localstack/localstack-ext/actions/runs/7799613007/job/21271112203 ext run fails with non-related tests only, so this should be good to go :) |
joe4dev approved these changes Feb 6, 2024
Member
joe4dev left a comment
joe4dev left a comment There was a problem hiding this comment.
I am happy to get these Lambda init update changes integrated 🚀 (at least a first iteration)
In the future, it would be great to support the Telemetry API to enable more Lambda extensions, and ultimately true X-ray tracing ✨
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We pulled upstream changes into our lambda init binary. (see localstack/lambda-runtime-init#30).
We should now update the binary, and set the account id in the environment, so it can properly returned when the
Lambda-Extension-Accept-Featureheader is set toaccountIdduring the extension register call (https://docs.aws.amazon.com/lambda/latest/dg/runtimes-extensions-api.html#extensions-registration-api-a)Changes